Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Kristy and Amal #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ashassan
Copy link

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? Method signature, parameters, and method body.
What are the advantages of using git when collaboratively working on one code base? Git allows you to get real-time updates while working together on the same piece of code. It also allows you to merge changes if you and a partner alter the same piece of code.
What kind of relationship did you and your pair have with the unit tests? We found them extremely useful. We used the tests at every step to make sure that our code was doing what it was supposed to.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used .max_by to determine the highest score, that way we could get the maximum value without using a variable and replacing it with the current iteration. We then used the highest score to figure out if there were multiple words with the same score.
What was one method you and your pair used to debug code? We used pry and rubber ducking to debug our code.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We discussed how we didn't shut each other down and explored all ideas. We also discussed how trading often helped us work effectively.

@jmaddox19
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions X
Small commits with meaningful commit messages Good job with the messages!
Code Requirements
draw_letters method X
Uses appropriate data structure to store the letter distribution Definitely a creative way to create the array of letters you need! Good job!
All tests for draw_letters pass X
uses_available_letters? method X
All tests for uses_available_letters? pass X
score_word method X
Uses appropriate data structure to store the letter scores X
All tests for score_word pass X
highest_score_from method X
Appropriately handles edge cases for tie-breaking logic X
All tests for highest_score_from pass X
Overall

I'm glad that it sounds like the pair programming went really well! Also I've never heard of the idea of rubber duck debugging before but I just looked it up and I LOVE that!

One minor thing: I noticed your uses_available_letters? method doesn't allow for lower case words to be entered. Allowing for lowercase wasn't in the requirements nor was it covered in the tests but it would've been a nice edge case to cover. We'll talk more about edge cases next week too :)

But really great job! Your code is very readable and succinct and (obviously) working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants