Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves_Ga-Young&Raisah #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Leaves_Ga-Young&Raisah #2

wants to merge 9 commits into from

Conversation

gyjin
Copy link

@gyjin gyjin commented Aug 14, 2019

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? Method name, parameters, and block. If a return is not otherwise specified, returns the last statement executed.
What are the advantages of using git when collaboratively working on one code base? Each person can individually fork from the code base, change the code, and suggest those changes back to the original code. Everyone can see the most updated code while also keeping multiple versions of their own code.
What kind of relationship did you and your pair have with the unit tests? At first, we didn't run the Rakefile after finishing wave-1 and manually tested our code. After hearing that other groups were running rake in between waves, we decided to run rake to find deficiencies in our code. While working on waves 2 - 4 we were aware that all parts of the test would not pass until the whole code was finished. The tests were helpful in determining which parts of our code were running correctly.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used has_key? to determine if a letters in the input word were part of the hand. We used .min to see if the input word used more letters than were available in the hand. We used .max_by and .min_by to compare lengths of the winning words in the event of a tie. These were "shortcuts" that made it easier to find specific data points without running nested loops.
What was one method you and your pair used to debug code? We put print statements within adagrams.rb because the rake and wave files couldn't tell us specific problems with how our code was running. After finishing each wave, we used wave files and the rake file to test overall function.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We shared our specific ask/guess cultures and how we best approach problem solving with another person. We both identified with guess culture which meant that we communicated well but also wanted to improve on being more direct. We checked in halfway through our project time to make sure that our communication style was working.

@dHelmgren
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions yes
Small commits with meaningful commit messages yes
Code Requirements
draw_letters method
Uses appropriate data structure to store the letter distribution yes
All tests for draw_letters pass yes
uses_available_letters? method
All tests for uses_available_letters? pass yes
score_word method
Uses appropriate data structure to store the letter scores yes
All tests for score_word pass yes
highest_score_from method
Appropriately handles edge cases for tie-breaking logic yes
All tests for highest_score_from pass yes
Overall Great code top to bottom, it's clear you really thought out the best tools you had for each step!


SIZE_OF_HAND.times do |i|
hand << shuffled_all_letters[i]
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid process here!

end
end

return hand_in_hash.values.min < 0 ? false : true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Clever! I dig it!

score += score_chart[char.to_sym]
end

score += 8 if word.length > 6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succinct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants