Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Sara & Farah #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

in-formation
Copy link

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? Method signature, return statement, parameters.
What are the advantages of using git when collaboratively working on one code base? Being able to see code via link/url as opposed to sending file back and forth.
What kind of relationship did you and your pair have with the unit tests? The unit tests were difficult but important to make sure our code worked. We had to refractor one Wave completely in order to pass its tests.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used .max method on an array and that helped establish the maximum value found in our array. Looking back, we could have potentially used the .sort_by method but that would have required a couple more hours to determine.
What was one method you and your pair used to debug code? Binding!!! It was super helpful! We were able to go through iterations step by step while determining what the current values of variables were. Also puts statements (which we deleted before turning in).
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? 1) Super helpful to write our thoughts/pseudocode down on paper as opposed to just typing away. That way it slowed us down and allowed us to discuss together. 2) Not just about the code but just good to learn extra shortcuts, methods, etc from each other. We both knew something that the other did not and that way we both learned from each other.

@jmaddox19
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions X
Small commits with meaningful commit messages Some of your commit messages could've been more detailed (like "Made changes for wave 5") and commits could've been made more frequently with smaller amounts of changes, but it looks like y'all are aware of that. It'll come more naturally over time.
Code Requirements
draw_letters method X
Uses appropriate data structure to store the letter distribution X
All tests for draw_letters pass X
uses_available_letters? method X
All tests for uses_available_letters? pass X
score_word method X
Uses appropriate data structure to store the letter scores Y'all didn't use a data structure but I'd say your case statement works just as well!
All tests for score_word pass X
highest_score_from method X
Appropriately handles edge cases for tie-breaking logic X
All tests for highest_score_from pass X
Overall Great job!!!

Y'all did such a good job!! Yay! 👏 👏 👏

I'm glad y'all found using binding.pry helpful! Also so glad y'all tried out starting on paper! I wish I'd thought to try that out earlier on in my practice with software, would've saved me so much frustration. And so glad y'all were able to learn shortcuts and stuff from each other!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants