Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Mira & Diana #7

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

dhan0406
Copy link

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? A method is made up of a signature and a body.
What are the advantages of using git when collaboratively working on one code base? We could easily see and compare each other's changes made to the code base and this prevented us from making any conflicting changes.
What kind of relationship did you and your pair have with the unit tests? We only started using the unit tests on day 3 because we had to work remotely, but by the time we were able to run the tests we had working code and were able to pass them.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used .map on line 6 to change the LETTER_POOL hash into an array of arrays.
What was one method you and your pair used to debug code? We printed variables to ensure that they were what we were expecting and also practiced commenting out lines to isolate issues. We also used pry to test our loops.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?

@jmaddox19
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Almost! I assume y'all just didn't notice the last question. Not a big deal :)
Small commits with meaningful commit messages X
Code Requirements
draw_letters method Super clever and succinct!
Uses appropriate data structure to store the letter distribution X
All tests for draw_letters pass X
uses_available_letters? method Also super clever and succinct!
All tests for uses_available_letters? pass X
score_word method Really efficient and clever the way you separated the data structures out of the method so they aren't getting re-created every time the method is called.
Uses appropriate data structure to store the letter scores X
All tests for score_word pass X
highest_score_from method Really cool that you broke break_tie into it's own method!
Appropriately handles edge cases for tie-breaking logic X
All tests for highest_score_from pass X
Overall So good! 👏👏👏

Y'all's code is so succinct and makes great use of built-in syntax that we have and haven't covered. Great job!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants