Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaves - Elizabeth Northrop #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leaves - Elizabeth Northrop #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
if array1.nil? && array2.nil?
true
elsif array1.nil? && array2 != nil
false
elsif array1 != nil && array2.nil?
false
elsif array1 == [] && array2 == []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're comparing the lengths later on, do you need these if statements?

true
elsif array1 == [] && array2 != []
false
elsif array1 != [] && array2 == []
false
elsif array1.length == array2.length
if array1 == array2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to traverse the arrays index-by-index and return false if they don't match. That's the point of this assignment.

true
else
false
end
elsif array1.length != array2.length
false
end
end