Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #7 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions print_list.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@

class Node {
constructor(value, next) {
this.value = value;
this.next = next;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I remember constructors

getNext() {
return this.next;
}

setNext(next) {
this.next = next;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this explicitly return something?


getValue() {
return this.value;
}

setValue(value) {
this.value = value;
}

printList() {
let current = this;

while (current != null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple

console.log(current.value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using .getValue() might honor encapsulation more

current = current.getNext();
}
}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is easy to understand.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and appreciate the descriptive function names

export default Node;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline at end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add New Line for Syntax