Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Hallie Johnson #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Leaves - Hallie Johnson #14

wants to merge 2 commits into from

Conversation

idhallie
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! You hit all the learning goals here. Well done.

Comment on lines +2 to 7
# Time Complexity: O(n); it iterates over each element in the nums array once.
# I don't think the max method adds meaningful time complexity. ?

# Space Complexity: O(1); makes the same number of variables regardless of nums size.
# Variables hold a single value and do not scale.
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

Comment on lines +3 to 5
# Time complexity: O(n); processes scale based upon num input
# Space Complexity: O(n); space needs are in proportion to num input.
def newman_conway(num)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants