Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raisah #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Raisah #18

wants to merge 2 commits into from

Conversation

rvesteinsdottir
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! You hit all the learning goals here. Well done.

Comment on lines +2 to +4
# Time Complexity: O(n) because the each loop will iterate through each item in the array
# Space Complexity: O(1) there are no additional data structures or recursive calls to add to space complexity
def max_sub_array(array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice use of the max method.

Comment on lines +1 to +3
# Time complexity: O(n) because the each loop is run n times
# Space Complexity: O(n) because there is an additional array solutions that varies linearly with size of n
def newman_conway(terms)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants