Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yasmin-Leaves #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,33 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)

def max_sub_array(nums)
Comment on lines +2 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
return 0 if nums == nil
# raise NotImplementedError, "Method not implemented yet!"
max_so_far = nums[0]
max_ending_here = 0

nums.each do |num|
max_ending_here = max_ending_here + num
if max_ending_here < num
max_ending_here = num
end
if max_so_far < max_ending_here
max_so_far = max_ending_here
end
end
return max_so_far
end

# Initialize:
# max_so_far = 0
# max_ending_here = 0

# Loop for each element of the array
# (a) max_ending_here = max_ending_here + a[i]
# (b) if(max_ending_here < 0)
# max_ending_here = 0
# (c) if(max_so_far < max_ending_here)
# max_so_far = max_ending_here
# return max_so_far
22 changes: 19 additions & 3 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@

# Time complexity: o(n)
# Space Complexity: o(n)

# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
Comment on lines +2 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done

raise NotImplementedError, "newman_conway isn't implemented"
# raise NotImplementedError, "newman_conway isn't implemented"
raise ArgumentError if num < 1
return "1" if num == 1
return "1 1" if num == 2

newman_conway = [0, 1, 1]
sequence = "1 1"

i = 3

while i <= num
#p(i) = p(p(i-1)) + p(i - p(i - 1))
newman_conway[i] = newman_conway[newman_conway[i - 1]] + newman_conway [i - newman_conway[i - 1]]
sequence += " #{newman_conway[i]}"
i += 1
end
return sequence
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down