Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Georgina #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,41 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)
return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
return 0 if nums == nil

j = 0
k = 0
while j < nums.length
if nums[j] < 0
k += 1
end
j += 1
end

if k == nums.length
return nums.max
else
return kadane(nums)
end
end


def kadane(nums)
return 0 if nums == nil

max_so_far = 0
max_ending_here = 0

i = 0
while i < nums.length
max_ending_here = max_ending_here + nums[i]
if(max_ending_here < 0)
max_ending_here = 0
elsif(max_so_far < max_ending_here)
max_so_far = max_ending_here
end
i+=1
end

return max_so_far
end
27 changes: 22 additions & 5 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,24 @@
# Time comPlexity: O(n)
# Space ComPlexity: O(n)
def p(n, memo)
if memo[n] != nil
return memo[n]
end
if n == 1 || n == 2
result = 1
else
result = p(p(n - 1, memo), memo) + p(n - p(n - 1, memo), memo)
end
memo[n] = result
return result
end

def newman_conway(n)
Comment on lines +1 to +16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice combination of recursion & dynamic programming.

if n == 0
raise ArgumentError
end

# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
end
memo = [nil,1]
p(n, memo)
return memo.join(" ").strip!
end
14 changes: 7 additions & 7 deletions test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down Expand Up @@ -46,14 +46,14 @@
end

it "will return nil for an empty array" do
# Arrange
input = []
# Arrange
input = []

# Act
answer = max_sub_array(input)
# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_be_nil
# Assert
expect(answer).must_be_nil
end

it "will work for [50, -50, 50]" do
Expand Down