Leaves - Georgina #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that I didn't do the tests for the wave 2. I added the tests. |
Grocery StoreWhat We're Looking For
|
dHelmgren
reviewed
Sep 3, 2019
|
|
||
| def self.all(file_name = 'data/customers.csv') | ||
| customers = [] | ||
| clients = CSV.read(file_name, headers: true).map(&:to_h) |
There was a problem hiding this comment.
It's worth thinking about how you would solve this problem if you couldn't edit the csv to have headers.
| attr_accessor :products, :customer, :fulfillment_status | ||
|
|
||
| def initialize(id, products, customer, fulfillment_status = :pending) | ||
| puts fulfillment_status |
There was a problem hiding this comment.
You need to take out puts statements before you submit! This is debugging code.
| @@ -0,0 +1,62 @@ | |||
| class Order | |||
| attr_reader :id | |||
| attr_accessor :products, :customer, :fulfillment_status | |||
There was a problem hiding this comment.
do all of these need to be accessors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grocery Store
Congratulations! You're submitting your assignment.
Comprehension Questions
raise ArgumentError?.all&.findmethods class methods? Why not instance methods?OrderandCustomer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project?Customerwas like planet and order was like solar system.Orderhas a one-to-many relation with customer.OrderandCustomertracked in the CSV file? How is it tracked in your program? Why might these be different?Oderwe used Customer.find to get the customer information and create a new order.