Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches Sara #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Branches Sara #35

wants to merge 2 commits into from

Conversation

sarashahbaig
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? If there is any bogus statuses it will raise an argumentError to indicates that something has gone wrong, Raising an exception will stop normal execution of the program and help either deal with the problem that's been encountered or exit the program completely.
Why do you think we made the .all & .find methods class methods? Why not instance methods? We cannot call an instance method on the class itself, and we cannot directly call a class method on an instance. The reason we didnt made them instance method is that we lead the finctionality from customer class without needing to create an instance of the customer.
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? Its relation is one-to-many because one customer can have many orders at the same time. How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different?
Did the presence of automated tests change the way you thought about the problem? How? Yes, it did. the autometed test helped me consider different aspect of my code that I otherwise not consider.

@jmaddox19
Copy link

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly I'd definitely recommend committing more frequently going forward.
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables X
Wave 2
All stubbed tests are implemented fully and pass No tests implemented
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all Not implemented
Order.all calls Customer.find to set up the composition relation X
Additional Notes Sorry you weren't able to get to finish Wave 2 and write the tests. We're all here to support you when you're having trouble :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants