Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Erika #39

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Branches - Erika #39

wants to merge 8 commits into from

Conversation

emaust
Copy link

@emaust emaust commented Aug 26, 2019

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? It prevents incorrect or duplicate information from being entered into an order
Why do you think we made the .all & .find methods class methods? Why not instance methods? By making them class methods, they were available to use on the entire class (all orders/customers) vs. one instance at a time
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? I think in this assignment the relation is one-to-one. One instance of a customer is tracking one instance of an order, not multiple orders, or one order for multiple customers. The solar system project was tracking one solar system with multiple planets, which I would label one to many.
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? The relation in the csv file is by including the customer id within the order row. In the program, it is tracked by assigning an order to a customer. They differ because the purpose of the csv file is to store data, while the point of the program is to interact with the data and be able to get specific information.
Did the presence of automated tests change the way you thought about the problem? How? It definitely influenced the way that I structured the program and also how I assigned and named my variables. It gave a pretty specific structure to what I needed to be writing out.

@jmaddox19
Copy link

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly X
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables In Customer, you have a reader and accessor for "customer" and "customers" which you don't have as instance variables in the class anywhere. I'm uncertain why those are there.
Wave 2
All stubbed tests are implemented fully and pass X
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all X
Order.all calls Customer.find to set up the composition relation X
Additional Notes So glad you recovered from the apocalypse! It looks great! I'm curious why you have two versions of Order (one in the file "order_prying.rb")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants