Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Vi #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Branches - Vi #43

wants to merge 3 commits into from

Conversation

criacuervos
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? You can enforce rules which are set by your code, and if you have a setter method where someone enters data that isn't the kind of data your code is meant to process. With an ArgumentError you can ensure that it won't pass through the constructor.
Why do you think we made the .all & .find methods class methods? Why not instance methods? It's information that belongs to the overall class of all orders and all customers, so we aren't looking to generate an instance.
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? One to many, because one individual customer can have many orders. In Solar System, one solar system could have many planets as well.
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? In the CSV file, orders have the id of the customer who ordered it. In the all method in my Order class I call on the Customer class to create an instance.
Did the presence of automated tests change the way you thought about the problem? How? I think so. It gave me small steps to orient myself around when I was looking for what to solve next.

@jmaddox19
Copy link

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly I'd definitely suggest committing more regularly moving forward.
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables X
Wave 2
All stubbed tests are implemented fully and pass X
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all X
Order.all calls Customer.find to set up the composition relation X
Additional Notes Looks great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants