Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Elizabeth #45

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Leaves - Elizabeth #45

wants to merge 8 commits into from

Conversation

north108
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? It tells the user that the information inputted is not correct information. It's data validation.
Why do you think we made the .all & .find methods class methods? Why not instance methods? They are class methods because they can be called without creating an instance of the class.
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? It is one-to-many. An order can only have one customer but a customer can have many orders. Customer is to sun as planet is to order.
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? In the CSV file it is tracked by customer id number. In the program it is tracked by an object of Customer. They are different because in the program it uses the customer id number to create an instance of Customer to attach to the order.
Did the presence of automated tests change the way you thought about the problem? How? It did because I had more of a direction to write my code because I wanted to make sure everything passed, not just that it worked.

@dHelmgren
Copy link

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions yes
Used Git Regularly yes
Wave 1
All provided tests pass yes
Using the appropriate attr_ for instance variables yes
Wave 2
All stubbed tests are implemented fully and pass yes
Used CSV library only in .all (not in .find) yes
Appropriately parses the product data from CSV file in Order.all yes
Order.all calls Customer.find to set up the composition relation yes
Additional Notes Solid work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants