Branches - Emily Ball #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2020 12:06
CheezItMan
reviewed
Mar 18, 2020
Comment on lines
+4
to
6
| # Time Complexity: O(n log n) | ||
| # Space Complexity: O(log n) - since using recurisve heap down | ||
| def heap_sort(list) |
There was a problem hiding this comment.
This works but since you're building a heap with n nodes, the space complexity is O(n).
| @@ -0,0 +1,91 @@ | |||
| require_relative "heap_node" | |||
|
|
|||
| class MaxHeap | |||
There was a problem hiding this comment.
Interesting that you built a max heap as well.
Comment on lines
+9
to
11
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def add(key, value = key) |
Comment on lines
+20
to
23
| # This method removes and returns an element from the heap maintaining the heap structure | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def remove() |
Comment on lines
+53
to
55
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? |
Comment on lines
+103
to
+111
| if @store[left_child] && @store[left_child].key < @store[index].key | ||
| swap(index, left_child) | ||
| heap_down_helper(left_child) | ||
| end | ||
|
|
||
| if @store[right_child] && @store[right_child].key < @store[index].key | ||
| swap(index, right_child) | ||
| heap_down_helper(right_child) | ||
| end |
There was a problem hiding this comment.
Doing it this way will work, but might lead to extra swaps if the right child is initially less than the left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?