Branches - Julia Bouvier #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 18, 2020
Comment on lines
+5
to
+7
| # Time Complexity: n(log(n)) | ||
| # Space Complexity: O(1) | ||
| def heapsort(list) |
There was a problem hiding this comment.
How do you have a space complexity of O(1)? You're building a new heap of n elements...
Otherwise this works.
Comment on lines
+17
to
19
| # Time Complexity: log(n) | ||
| # Space Complexity: log(n) | ||
| def add(key, value = key) |
Comment on lines
+26
to
28
| # Time Complexity: log(n) | ||
| # Space Complexity: log(n) | ||
| def remove() |
| def empty? | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| return true if @store.length == 0 |
There was a problem hiding this comment.
Suggested change
| return true if @store.length == 0 | |
| return @store.length == 0 |
Comment on lines
+53
to
55
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def empty? |
There was a problem hiding this comment.
How is this O(n) time complexity? Otherwise it works.
Comment on lines
+64
to
66
| # Time complexity: log(n) | ||
| # Space complexity: log(n) | ||
| def heap_up(index) |
| lc_index = index * 2 + 1 | ||
| rc_index = index * 2 + 2 | ||
| return if @store[lc_index].nil? && @store[rc_index].nil? | ||
| return if index == @store.length - 1 |
There was a problem hiding this comment.
I think this line is unnecessary since if they are at the end of the array, they have no children.
| return if index == 0 || @store[index].key >= @store[parent_index].key | ||
|
|
||
| swap(index, parent_index) | ||
| return heap_up(parent_index) | ||
| end | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?