Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Nicky C. #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@

require_relative './min_heap'

# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(nlogn)
# Space Complexity: O(n)
def heap_sort(list)
Comment on lines +4 to 6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
size = list.length
return list if size == 0 || size == 1

heap = MinHeap.new
i = 0

while i < size
heap.add(list[i])
i += 1
end

i = 0
while i < size
result = heap.remove
list[i] = result
i += 1
end
return list
end
85 changes: 57 additions & 28 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
@@ -1,77 +1,106 @@
class HeapNode
attr_reader :key, :value

def initialize(key, value)
@key = key
@value = value
end
end

class MinHeap

def initialize
@store = []
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(logn)
# Space Complexity: O(1)
def add(key, value = key)
Comment on lines +16 to 18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)

heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(logn)
# Space Complexity: O(1)
def remove()
Comment on lines +26 to 28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return nil if @store.empty?
return @store[0].value if @store.length == 1

swap(0, @store.length - 1)
result = @store.pop
heap_down(0) unless @store.empty?
return result.value
end



# Used for Testing
def to_s
return "[]" if @store.empty?

output = "["
(@store.length - 1).times do |index|
output += @store[index].value + ", "
end

output += @store.last.value + "]"

return output
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +53 to 55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return true if @store.empty?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return true if @store.empty?
return @store.empty?

end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(logn)
# Space complexity: O(logn)
def heap_up(index)
Comment on lines +64 to 66

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just note how this impacts the space complexity of add.

parent_index = (index - 1) / 2

if @store[parent_index].key > @store[index].key && index != 0
swap(parent_index, index)
heap_up(parent_index)
end
end

# This helper method takes an index and
# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
left_child = index * 2 + 1
right_child = index * 2 + 2
return if @store[left_child].nil? && @store[right_child].nil?

if @store[right_child].nil?
smallest_child = left_child
else
if @store[left_child].key < @store[right_child].key
smallest_child = left_child
else
smallest_child = right_child
end
end

if @store[index].key > @store[smallest_child].key
swap(smallest_child, index)
heap_down(smallest_child)
end
return
end

# If you want a swap method... you're welcome
def swap(index_1, index_2)
temp = @store[index_1]
@store[index_1] = @store[index_2]
@store[index_2] = temp
end
end
end
22 changes: 11 additions & 11 deletions test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []

# Act
result = heapsort(list)

result = heap_sort(list)
# Assert
expect(result).must_equal []
end

it "can sort a 1-element array" do
# Arrange
list = [5]

# Act
result = heapsort(list)

result = heap_sort(list)
# Assert
expect(result).must_equal [5]
end

it "can sort a 5-element array" do
# Arrange
list = [5, 27, 3, 16, -50]

# Act
result = heapsort(list)

result = heap_sort(list)
# Assert
expect(result).must_equal [-50, 3, 5, 16, 27]
end
Expand Down