Sara - Branches #28
Open
Sara - Branches #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 19, 2020
Comment on lines
+4
to
6
| # Time Complexity: o(logn) | ||
| # Space Complexity: o(n) | ||
| def heap_sort(list) |
Comment on lines
+17
to
19
| # Time Complexity: o(logn) | ||
| # Space Complexity: o(logn) | ||
| def add(key, value = key) |
Comment on lines
+27
to
29
| # Time Complexity: o(logn) | ||
| # Space Complexity: o(1) i think | ||
| def remove() |
There was a problem hiding this comment.
Since heap_down is recursive this is O(log n) for time complexity just like add
Comment on lines
+53
to
55
| # Time complexity: o(1) | ||
| # Space complexity: o(1) | ||
| def empty? |
Comment on lines
+65
to
67
| # Time complexity: o(logn) | ||
| # Space complexity: o(1) | ||
| def heap_up(index) |
There was a problem hiding this comment.
See add for notes on time complexity, otherwise 👍
| return | ||
| end | ||
|
|
||
| if @store[left_index].key < @store[right_index].key |
There was a problem hiding this comment.
You also need to compare the child to the current element.
Suggested change
| if @store[left_index].key < @store[right_index].key | |
| if @store[left_index].key < @store[right_index].key && @store[left_index].key < @store[index].key |
| if @store[left_index].key < @store[right_index].key | ||
| swap(left_index, index) | ||
| heap_down(left_index) | ||
| else |
There was a problem hiding this comment.
Suggested change
| else | |
| elsif @store[right_index].key < @store[index].key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions