Leaves - Mariya #30
Leaves - Mariya #30
Conversation
| # Time Complexity: O (n log (n)) | ||
| # Space Complexity: O(n) | ||
| def heap_sort(list) |
| # Time Complexity: O(log(n)) | ||
| # Space Complexity: O(1) | ||
| def add(key, value = key) |
There was a problem hiding this comment.
Since heap_up is recursive the space complexity is O(log n)
| # Time Complexity: O(log(n)) | ||
| # Space Complexity: O(1) | ||
| def remove() |
There was a problem hiding this comment.
👍 However like add the space complexity is O(log n)
| if @store.length == 0 | ||
| return true | ||
| else | ||
| return false | ||
| end |
There was a problem hiding this comment.
| if @store.length == 0 | |
| return true | |
| else | |
| return false | |
| end | |
| return @store.length == 0 |
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? |
| while parent > 0 | ||
| return heap_up(parent) | ||
| end |
There was a problem hiding this comment.
Note you're making extra recursive calls here. You only want to heap_up if you made a swap, and since you're returning here you don't need a while loop.
| # Time complexity: O(log (n)) | ||
| # Space complexity: O(1) | ||
| def heap_up(index) |
There was a problem hiding this comment.
Since this is a recursive method, it's going to be O(log n) space complexity.
| swap(index, smallest_child) | ||
| end | ||
|
|
||
| return heap_down(smallest_child) |
There was a problem hiding this comment.
Similar to the heap_up method you're making extra recursive calls. You only need to continue to heap_down if you make a swap.
| end | ||
|
|
||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) |
There was a problem hiding this comment.
This works, but it has issues with extra swaps.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?