Leaves - Yitgop #37

rinostar · 2019-09-09T07:56:54Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Trying to balance between clear logic flow among classes and the new design knowledges from POODR.
What was a design decision you made that changed over time over the project?	Over the course of the project, the DateRange class seems to serve no functions other than hold check in and check out time for reservations. Therefore, I decided to merge that function to Reservation, and got ride of DateRange class.
What was a concept you gained clarity on, or a learning that you'd like to share?	I understand the interaction of different classes within the same module better now.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	You can't make an reservation when check out date is earlier than check in date. It is a nominal case because the parameter of check in and check out dates expect Date instances input.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	When the argument for Booker's "inventory" parameter is non-integer, it will raise an ArgumentError. It is a edge case because the parameter doesn't not expect a integer input.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It definitely took longer in the beginning, but provided better workflow and design opportunities later on.

…to Booker, and "total_cost" to Reservation

beccaelenzil · 2019-09-11T18:32:12Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	100% - You should not commit your coverage directory to github. Add this directory to git ignore.
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	booker, 93.85% -- try to see what you're missing.. is it necessary code?
Wave 3	N/A
Create a block of rooms	N/A
Check if a block has rooms	N/A
Reserve a room from a block	N/A
Test coverage	N/A

Code Review

Baseline	Feedback
Used git regularly	increase the frequency of your commits.
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself! Your code is clear and your design helps you achieve all the requirements.

beccaelenzil · 2019-09-11T18:22:51Z

lib/booker.rb

+      @rooms = []
+      @reservations = []
+
+      if @inventory.class != Integer


This error checking should go ahead of the assignment to @inventory

beccaelenzil · 2019-09-11T18:23:22Z

lib/booker.rb

+
+    end
+
+    def all_rooms


How is this different than the rooms reader method.

beccaelenzil · 2019-09-11T18:26:04Z

test/booker_test.rb

+
+  end
+
+  describe "all_rooms method" do 


I like this inventory feature, but your hotel was supposed to have 20 rooms.

beccaelenzil · 2019-09-11T18:27:39Z

test/booker_test.rb

+
+    it "throws ArgumentError when there is no available rooms during the given date range" do 
+      rooms = @new_booker.rooms
+      rooms[0].bookings << Hotel::Reservation.new(check_in: "2019-09-01", check_out: "2019-09-04", room: 1)


Consider storing the dates in variables so it is clear what you are testing.

Suggested change

rooms[0].bookings << Hotel::Reservation.new(check_in: "2019-09-01", check_out: "2019-09-04", room: 1)

check_in_date = "2019-09-01"

check_out_date = "2019-09-04"

beccaelenzil · 2019-09-11T18:29:08Z

test/room_test.rb

+      expect(Hotel::Room.new(number: 3).bookings.length).must_equal 0
+    end
+
+    # it "adds booking to the bookings array if provided" do


remove commented code

beccaelenzil · 2019-09-11T18:29:53Z

test/reservation_test.rb

+      expect(Hotel::Reservation.new(check_in: check_in, check_out: check_out).room).must_equal nil
+    end
+
+    it "is set up for specific attributes and data types" do


nice separation of Act/Arrange/Assert in this test.

beccaelenzil · 2019-09-11T18:30:11Z

test/reservation_test.rb

+    it "sets room to nil if not provided" do
+      check_in = "2019-09-01"
+      check_out = "2019-09-04"
+      expect(Hotel::Reservation.new(check_in: check_in, check_out: check_out).room).must_equal nil


I think there's a .must_equal_nil method.

beccaelenzil · 2019-09-11T18:30:41Z

test/booker_test.rb

+
+  end
+
+  describe "make_reservation method" do


Nice, comprehensive tests.

rinostar added 7 commits September 3, 2019 17:07

set up Room class

4dd4933

Set-up 3 classes: Room, DateRange, Reservation

429ef08

redesig & set up classes: Room, Reservation, Booker, Block

5839fca

Updated set-up for the three classes

99065a9

Wave_1 : added "all_rooms", "make_reservation", "search_reservation" …

d17fa77

…to Booker, and "total_cost" to Reservation

Wave_2: added "available-rooms" method to Booker class

0f46617

Updated tests files (95.79% code coverage) & Added "refactor.txt

cc01dc7

beccaelenzil reviewed Sep 11, 2019

View reviewed changes

rinostar added 7 commits September 28, 2019 16:06

added and finished design-activity.md

e1ed08d

Add coverage to .gitignore

26d497c

ignore coverage try 2

027fb07

coverage ignore try#3

e3901ee

refactor based on feedback

3a39c68

Implement re-design

83b0002

final commit

03b0557

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaves - Yitgop #37

Leaves - Yitgop #37

rinostar commented Sep 9, 2019

beccaelenzil commented Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

beccaelenzil Sep 11, 2019

	rooms[0].bookings << Hotel::Reservation.new(check_in: "2019-09-01", check_out: "2019-09-04", room: 1)
	check_in_date = "2019-09-01"
	check_out_date = "2019-09-04"

Leaves - Yitgop #37

Are you sure you want to change the base?

Leaves - Yitgop #37

Conversation

rinostar commented Sep 9, 2019

Hotel

Comprehension Questions

beccaelenzil commented Sep 11, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment