Dominique - Leaves #42

dtaylor73 · 2019-09-09T15:14:32Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Trying to decide if I needed a rooms class or not and trying to decide if I should add in an instance variable called "available" to that room class.
What was a design decision you made that changed over time over the project?	The hotel_system class originally had an array of integers for its rooms instance variable. However, I changed it to include an array of room objects. My thinking was that this would make things easier down the road if I needed to change anything.
What was a concept you gained clarity on, or a learning that you'd like to share?	I gained clarity on before blocks and class variables.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	I wrote a nominal test in hotel_system that tested if the list_rooms method returned an array of 20 room objects. This is nominal because this it is testing that the method behaves as it is expected to.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	I wrote a test to ensure that an argument error was raised when invalid date ranges were given. This is an edge case because it tests the user's "worst case scenario" input or the edges of what can be provided.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	Very well. Pseudocode was the most helpful.

…est.rb

dHelmgren · 2019-09-16T02:03:59Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	good
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	good
Wave 3	DNF
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage

Code Review

Baseline	Feedback
Used git regularly	Good
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	No, the `HotelSystem` owns too much of the responsibility
Classes are loosely coupled	no due to the above.
Fundamentals
Names variables, classes and modules appropriately	Yes, but method names are often similar. :(
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	Mostly, look for opportunities to delegate.
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you broke down larger problems into bite-sized methods.

I do see some room for improvement around removing code that causes warnings, better delegation among classes and less redundant method names.

dHelmgren · 2019-09-16T01:44:13Z

test/hotel_system_test.rb

@@ -0,0 +1,105 @@
+require_relative "test_helper"
+require "Pry"


you left in all of your require 'pry''s, which causes a warning.

dHelmgren · 2019-09-16T01:45:23Z

lib/hotel_system.rb

+      found_reservations
+    end
+
+    def list_available_rooms (start_date, end_date)


/Users/devin/Documents/Ada/c12/hotel/lib/hotel_system.rb:52: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

This is because you put a space after list_available_rooms

dHelmgren · 2019-09-16T01:46:05Z

test/hotel_system_test.rb

+      start_date = Date.parse("2019-02-08")
+      end_date = Date.parse("2019-02-12")
+
+      result = @hotel_system.make_reservation(start_date, end_date)


/Users/devin/Documents/Ada/c12/hotel/test/hotel_system_test.rb:61: warning: assigned but unused variable - result

dHelmgren · 2019-09-16T01:47:58Z

lib/date_range.rb

+
+    def initialize(start_date: , end_date:)
+      @start_date = start_date
+      @end_date = end_date


If you use a class without any methods besides initialize, you probably either don't need a class or your other classes are doing work that belongs to the empty class.

dHelmgren · 2019-09-16T01:50:02Z

lib/hotel_system.rb

+
+        if (reservation.date_range.start_date >= start_date && reservation.date_range.start_date < end_date) || 
+          (reservation.date_range.end_date >= start_date && reservation.date_range.end_date <= end_date)
+          reserved_room_numbers.push(reservation.room.room_number)


The discussion of POODR chapter 4 probably helps here: your Hotel class should be delegating this work to the other two classes as in the example that I gave.

dHelmgren · 2019-09-16T01:59:04Z

lib/hotel_system.rb

+    end
+
+    def list_available_room_numbers(start_date, end_date)
+      available_rooms = list_available_rooms(start_date, end_date)


list_available_room_numbers calls list_available_rooms. This is confusing. :(

dHelmgren · 2019-09-16T02:02:17Z

lib/refactors.txt

+  in hotel system is an array of room objects, it made it harder to access the room numbers. I ended up making unnecessary methods in hotel system
+  like "list_available_room_numbers" because I had to extract the room numbers from the room objects. If I had no room class and 
+  simply just made the rooms instance variable in hotel system an array of integers 1 -20, I wouldn't need the extra methods.
+  Also, there was no reason to list the room cost. Every room is $200 and total cost is calculated in the reservations class. 


That seems wrong to me? Isn't it 200 per day?

dtaylor73 added 12 commits September 4, 2019 15:22

Date_Range instantiation

e4ddc91

throws an argument error if start date is after end date date_range_t…

3d0277d

…est.rb

room instantiation room_test.rb

3bc0174

load_all method test

4d3d56a

hotel_system instantiation tests

190aac8

list_rooms method added

4a8713e

Wave 1 complete

e7c6c60

Wave 2 list_available_rooms test passed

5d9afc4

Wave 2 complete

c099b5c

created refactors.txt file

45840af

final submission

9e28570

created refactors.txt

33bd604

dHelmgren reviewed Sep 16, 2019

View reviewed changes

dtaylor73 added 2 commits September 26, 2019 14:56

design-activity.md

be2b253

Hotel redesign

fe02589

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dominique - Leaves #42

Dominique - Leaves #42

dtaylor73 commented Sep 9, 2019

dHelmgren commented Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

dHelmgren Sep 16, 2019

		@@ -0,0 +1,105 @@
		require_relative "test_helper"
		require "Pry"

Dominique - Leaves #42

Are you sure you want to change the base?

Dominique - Leaves #42

Conversation

dtaylor73 commented Sep 9, 2019

Hotel

Comprehension Questions

dHelmgren commented Sep 16, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment

dHelmgren Sep 16, 2019

Choose a reason for hiding this comment