Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Dora #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Branches - Dora #22

wants to merge 4 commits into from

Conversation

dora1405
Copy link

@dora1405 dora1405 commented Dec 7, 2019

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? LinkedList can add or delete nodes without having to create a new array when length of list changes unlike what happens 'underneath the hood' in an Array data structure. Also nodes of a LinkedList can be located anywhere in memory. Arrays allocate each element in a contiguous block.
2. When is an Array more advantageous? Array knows the index of its elements, which would be a time complexity of O(1). LinkedList does not know the index of its nodes so its time complexity when trying to find the value of its 'index' is O(n).
3. When is an LinkedList more advantageous? When you don't know the size of the array because with LinkedList you can change the size of the list, but for arrays the size needs to be known beforehand; otherwise, in Ruby it will create a new array when the size changes.

CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the learning goals here. You do have one bug with the final method, but otherwise excellent work. Take a look at my comments and let me know if you have questions.

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_last

current = head
if current.nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_last
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_at_index(index)

current = head
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index is greater than the length of the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dora1405 @CheezItMan