Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Julia Bouvier #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Branches - Julia Bouvier #26

wants to merge 2 commits into from

Conversation

juliabouv
Copy link

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? Dynamic allocation of memory.
2. When is an Array more advantageous? When you know how many items will be in the list, or you want to be able to access items frequently by index number.
3. When is an LinkedList more advantageous? LinkedList is preferable when you don't know how many items will be in the list.

CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n)
# Space complexity - O(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
end

previous = nil
node = @head
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a better variable name might be current_node

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_last

previous = nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
previous = nil
return nil if head.nil?
previous = nil

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n)
# Space complexity - O(1)
def get_at_index(index)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index is greater than the length of the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliabouv @CheezItMan