-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaves - Georgina #32
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -7,39 +7,72 @@ def initialize | |||||||
@head = nil | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) | ||||||||
# Space complexity - O(1) | ||||||||
def add_first(data) | ||||||||
|
||||||||
@head = Node.new(data, head) | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(1) | ||||||||
# Space complexity - O(1) | ||||||||
def get_first | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
|
||||||||
return nil if @head.nil? | ||||||||
return @head.data | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def length | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
return 0 | ||||||||
current = @head | ||||||||
counter = 0 | ||||||||
until current.nil? | ||||||||
counter += 1 | ||||||||
current = current.next | ||||||||
end | ||||||||
return counter | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def add_last(data) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||
|
||||||||
new_node = Node.new(data) | ||||||||
|
||||||||
if @head == nil | ||||||||
@head = new_node | ||||||||
else | ||||||||
current = @head | ||||||||
until current.next.nil? | ||||||||
current = current.next | ||||||||
end | ||||||||
current.next = new_node | ||||||||
end | ||||||||
|
||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def get_last | ||||||||
|
||||||||
current = @head | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if
Suggested change
|
||||||||
until current.next.nil? | ||||||||
current = current.next | ||||||||
end | ||||||||
return current.data | ||||||||
end | ||||||||
|
||||||||
# Time complexity - ? | ||||||||
# Space complexity - ? | ||||||||
# Time complexity - O(n) | ||||||||
# Space complexity - O(1) | ||||||||
def get_at_index(index) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if index is greater than the length of the list? |
||||||||
|
||||||||
current = @head | ||||||||
(index).times do | ||||||||
if current == nil | ||||||||
return nil | ||||||||
else | ||||||||
current = current.next | ||||||||
end | ||||||||
end | ||||||||
if current == nil | ||||||||
return nil | ||||||||
end | ||||||||
return current.data | ||||||||
end | ||||||||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍