Branches - Erika #41
Open
Branches - Erika #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2019
There was a problem hiding this comment.
You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.
Also you should look at the time/space complexities of the methods. It will help you identify when a linked list is more or less optimal a choice.
| @@ -10,36 +10,75 @@ def initialize | |||
| # Time complexity - ? | |||
| # Space complexity - ? | |||
| def add_first(data) | |||
| curr = curr.next | ||
| end | ||
| return curr.data | ||
| end | ||
| end | ||
|
|
||
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| def get_at_index(index) |
There was a problem hiding this comment.
What about if the index is greater than the length of the list?
| end | ||
|
|
||
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| def get_last | ||
|
|
||
| curr = @head |
There was a problem hiding this comment.
What if head is nil?
Suggested change
| curr = @head | |
| return nil if @head.nil? | |
| curr = @head |
| count += 1 | ||
| curr = curr.next | ||
| end | ||
| return count | ||
| end | ||
|
|
||
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| def add_last(data) |
Comment on lines
10
to
11
| # Time complexity - ? | ||
| # Space complexity - ? |
There was a problem hiding this comment.
No guesses on time/space complexity?
| @@ -10,36 +10,75 @@ def initialize | |||
| # Time complexity - ? | |||
| # Space complexity - ? | |||
| def add_first(data) | |||
|
|
|||
| @head = Node.new(data, @head) | |||
| end | |||
|
|
|||
| # Time complexity - ? | |||
| # Space complexity - ? | |||
| def get_first | |||
| return nil | ||
| else | ||
| return @head.data | ||
| end | ||
| end | ||
|
|
||
| # Time complexity - ? | ||
| # Space complexity - ? | ||
| def length |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked List Comprehension Questions