Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Bri #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions lib/problems.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,46 @@
require_relative './stack.rb'

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def balanced(string)
Comment on lines +3 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the right idea here with one typo. See below.

Do consider using a hash, it could make the code more compact.

raise NotImplementedError, "Not implemented yet"
# is it evenly divided by 2? If yes, then return false
# equal number of open parans and close parens
# make a new stack, make balanced = true
# go through each string using each_char
# if open parens, push to stack
# if close parens, check if stack has this match. If yes, pop off match in stack
# if at end, stack is empty, it is balanced. If parens remains, it is not balanced

if string.length % 2 == 1
return false
end

stack = Stack.new

string.each_char do |char|
if char == '('
stack.push '('
elsif char == ')' && stack.pop != '('
return false
end

if char == '{'
stack.push '}'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close brace?

elsif char == '}' && stack.pop != '{'
return false
end

if char == '['
stack.push '['
elsif char == ']' && stack.pop != '['
return false
end
end
return true
end

# Time Complexity: ?
# Space Complexity: ?
def evaluate_postfix(postfix_expression)
raise NotImplementedError, "Not implemented yet"
end
# def evaluate_postfix(postfix_expression)
# raise NotImplementedError, "Not implemented yet"
# end
11 changes: 6 additions & 5 deletions lib/queue.rb
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
require 'linked_list.rb'

class Queue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the Queue you were supposed to use a circular buffer. So this works, but it's not the assignment.


def initialize
# @store = ...
raise NotImplementedError, "Not yet implemented"
@store = LinkedList.new
end

def enqueue(element)
raise NotImplementedError, "Not yet implemented"
@store.add_last(element)
end

def dequeue
raise NotImplementedError, "Not yet implemented"
return @store.remove_first
end

def front
Expand All @@ -22,7 +23,7 @@ def size
end

def empty?
raise NotImplementedError, "Not yet implemented"
return @store.empty?
end

def to_s
Expand Down
11 changes: 6 additions & 5 deletions lib/stack.rb
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
require 'linked_list.rb'

class Stack
def initialize
# @store = ...
raise NotImplementedError, "Not yet implemented"
@store = LinkedList.new
end

def push(element)
raise NotImplementedError, "Not yet implemented"
@store.add_last(element)
end

def pop
raise NotImplementedError, "Not yet implemented"
return @store.remove_last
end

def empty?
raise NotImplementedError, "Not yet implemented"
return @store.empty?
end

def to_s
Expand Down