Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Emily Ball #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Branches - Emily Ball #34

wants to merge 4 commits into from

Conversation

eaball35
Copy link

@eaball35 eaball35 commented Oct 7, 2019

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Our models connect us to our databases
Describe in your own words what the Controller is doing in Rails Controller is responsible for handling requests and sending back a responses - central messenger
Describe in your own words what the View is doing in Rails View is displaying the data in easy to process way
Describe an edge-case controller test you wrote If an invalid task id is passed in it should redirect
What is the purpose of using strong params? (i.e. the params method in the controller) So the user can't edit information we don't want to them
How are Rails migrations related to Rails models? We have to do migrations to perform updates on the models
Describe one area of Rails that are still unclear on I need more help with testing and writing controller methods

@jmaddox19
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Oh no! It looks like you didn't commit for 4 days. I assume maybe something went wrong with your git history or something.
Answered comprehension questions X
Successfully handles: Index, Show X
Index & Show tests pass X
Successfully handles: New, Create X
New & Create tests pass X
Successfully handles: Edit, Update X
Tests for Edit & Update test valid & invalid task ids X
Successfully handles: Destroy, Task Complete X
Tests for Destroy & Task Complete include tests for valid and invalid task ids X
Routes follow RESTful conventions Minor thing: Because complete and uncomplete are updating state, they're conventionally be patch requests.
Uses named routes (like _path) X
Overall Great job! Your site looks like it's ready to go to market with how good it looks and works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants