Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Xinran #35

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Branches - Xinran #35

wants to merge 6 commits into from

Conversation

gracexinran
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Read and modify data in the database
Describe in your own words what the Controller is doing in Rails Take request from router, pull information from database and make decisions to do tasks
Describe in your own words what the View is doing in Rails Show the layout for browser request
Describe an edge-case controller test you wrote Redirect to index page if the task_id requested by browser does not exist
What is the purpose of using strong params? (i.e. the params method in the controller) Avoid user updated data incorrectly and make our code DRY
How are Rails migrations related to Rails models? We write a migration to create a new model and can make following migrations to modify the schema of this model.
Describe one area of Rails that are still unclear on router prefix with parameters(arguments)

…created index, show, new, create, edit and update controller methods; created views for index, show, new and edit methods
…, uncomplete methods; created css; created unit tests of nonimal cases for edit, update, destroy, complete and uncomplete methods; changed time zone in controller to display time locally
…dded edge cases for 'update', 'destroy', 'complete' and 'incomplete' methods in controller test
@tildeee
Copy link

tildeee commented Oct 14, 2019

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in x
Answered comprehension questions x
Successfully handles: Index, Show x
Index & Show tests pass x
Successfully handles: New, Create x
New & Create tests pass x
Successfully handles: Edit, Update x
Tests for Edit & Update test valid & invalid task ids x
Successfully handles: Destroy, Task Complete x
Tests for Destroy & Task Complete include tests for valid and invalid task ids x
Routes follow RESTful conventions x
Uses named routes (like _path) x
Overall

Great work on this project, Xinran! Your TaskList looks and works great! And your tests are very complete and work great too.

I only have a minor comment on how to make a test more thorough!

Other than that, your TaskList looks great. Keep up the great work!

# Your tests go here
it "must update the completed time to nil and redirect to index page" do
patch uncomplete_task_path(task.id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: It might be nice to check that Task.count won't change here, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants