Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Brianna K #36

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Branches - Brianna K #36

wants to merge 28 commits into from

Conversation

brikemp
Copy link

@brikemp brikemp commented Oct 7, 2019

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model is the link to the database, it is responsible for providing access and allowing updates to our data
Describe in your own words what the Controller is doing in Rails The controller handles requests and passes info (in HTML form) back to users
Describe in your own words what the View is doing in Rails The layout for the user
Describe an edge-case controller test you wrote A test to confirm that trying to delete a task that was already deleted will not lead to an error, but instead redirects to the task list
What is the purpose of using strong params? (i.e. the params method in the controller) To DRY code and improve security of the site
How are Rails migrations related to Rails models? Rails migrations are responsible for updating rails models
Describe one area of Rails that are still unclear on Creating custom routes and using the correct HTTP verbs

@jmaddox19
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Yes!
Answered comprehension questions X
Successfully handles: Index, Show X
Index & Show tests pass X
Successfully handles: New, Create X
New & Create tests pass X
Successfully handles: Edit, Update X
Tests for Edit & Update test valid & invalid task ids X
Successfully handles: Destroy, Task Complete Yes! (One minor thing: Clicking the complete button results in a rails "unhandled error" page if its clicked without any tasks checked. This is just an edge case I tested out.)
Tests for Destroy & Task Complete include tests for valid and invalid task ids X
Routes follow RESTful conventions X
Uses named routes (like _path) X
Overall It looks so good! I love the design choice with the table and the ability to mark multiple tasks as completed at once!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants