Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Diana Han #46

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Branches - Diana Han #46

wants to merge 6 commits into from

Conversation

dhan0406
Copy link

@dhan0406 dhan0406 commented Oct 7, 2019

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Model is how we communicate with the db through Active Record. We treat it like classes in that we use methods like, Task.all.
Describe in your own words what the Controller is doing in Rails Controller contains all the action and is in charge of handling requests and sending back responses. The controller also uses instance variables to communicate with the views.
Describe in your own words what the View is doing in Rails The view is what the user sees in the browser. It is similar to a CLI and we use html to create what the view appears like to the user.
Describe an edge-case controller test you wrote An edge-case I considered was for the update action, that my program will redirect to the root page when an id: -1 was entered.
What is the purpose of using strong params? (i.e. the params method in the controller) The purpose of strong params is to store them as a private method and is a secure way of getting data from our users.
How are Rails migrations related to Rails models? A migration is used to manipulate the table in the db. We need to create migrations to create a new table or manipulate the columns.
Describe one area of Rails that are still unclear on I could use more clarification on routes, especially the ones that link to more than one action. For example, the new_book_path leads users to the new form action and then the create action. I think I need more clarification on when and how the create actions gets triggered.

@jmaddox19
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in I would recommend making a habit of committing more frequently. Probably anytime you create a new action and see it working, for instance. For future reference, you don't need to commit any files in the 'bin/' 'config/' or 'public' folders. If you look and see that way more files are listed than you expect, that's a probably sign that you committed something you didn't need to. (In this case 95 files.)
Answered comprehension questions Yes
Successfully handles: Index, Show yes! (Minor: A little curious why "show" view has "please" at the start of the description.)
Index & Show tests pass Yes!
Successfully handles: New, Create Yes!
New & Create tests pass Yes!
Successfully handles: Edit, Update Yes!
Tests for Edit & Update test valid & invalid task ids Yes!
Successfully handles: Destroy, Task Complete Yes!
Tests for Destroy & Task Complete include tests for valid and invalid task ids Yes! (One missing test for redirecting if the id is invalid in mark_complete. Not a big deal)
Routes follow RESTful conventions Yes!
Uses named routes (like _path) Yes!
Overall Great job! Even got some practice with partial views in there! It all looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants