Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Kristina #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leaves - Kristina #29

wants to merge 1 commit into from

Conversation

krismosk
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the basic learning goals, with some issues on space/time complexity. I.e., you didn't do that part. You also left some typos in which prevented tests from running. Check out my comments and let me know if you have any questions.

Comment on lines 33 to +35
# Time Complexity:
# Space Complexity:
def add(key, value)
raise NotImplementedError
def add(key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space and time complexity?

Comment on lines 57 to 59
# Time Complexity:
# Space Complexity:
def find(key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space and time complexity?

Comment on lines 73 to +75
# Time Complexity:
# Space Complexity:
def inorder
raise NotImplementedError
def inorder(node,)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space and time complexity?

Comment on lines 80 to +82
# Time Complexity:
# Space Complexity:
def preorder
raise NotImplementedError
def preorder_helper(current_node, list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space and time complexity?

Comment on lines 97 to +99
# Time Complexity:
# Space Complexity:
def postorder_helper(current_node, list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space and time complexity?

return list
end

def pre_order

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def pre_order
def preorder

end

# Time Complexity:
# Space Complexity:
def inorder
raise NotImplementedError
def inorder(node,)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def inorder(node,)
def inorder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants