Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Hallie / Janice #27

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open

Leaves - Hallie / Janice #27

wants to merge 92 commits into from

Conversation

idhallie
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C12/video-store-consumer-api#19
For each person in your pair, describe something you learned from your partner during this project Hallie: I learned new git commands from Janice. Janice: I learned how to implement React Router and some CSS tricks from Hallie.
What was one area of React you gained more clarity on during this assignment? We're feeling more comfortable with how to pass props and use callback functions.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We created entirely different components for search results and the movie library items.
Describe how you handled rentals with React We use an onSelect method that updates State in App and if both the currentCustomer and currentMovie fields in state are not blank, we display buttons to check out or check-in.
Describe a DOM event your application handled We have a bunch of onClick things and componentDidMounts, and even componentWillUnmount. Whee!
Did you use any functional stateless components? What for? Yes. Feedback and Search.
Did you use any container components? What for? Yes! For the search function, we split it up into the Search component (container) and SearchResults (presentational).
Do you have any recommendations on how we could improve this project for the next cohort? Perhaps being more explicit about the wrapper function. Luckily, we talked to others enough to learn that we didn't have to build that functionality, but it was close!

idhallie and others added 30 commits December 16, 2019 16:29
Added library component. It displays all titles.
Added content and styling to Library component.
Added router stuff--changed formatting in App.
Added Customers component.
…ent, add searchResultToLibrary function that makes an axios call
Can also select a movie for Selection box.
Inching toward check-out post request.
janicewhuang and others added 30 commits December 19, 2019 16:27
reverted selection stuff. gah.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants