Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Sairagul - Static-Site #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

sairagula
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I did not use this tool, forgot about it. It would have been a lot easier with it :)
Why is it important to consider and use semantic HTML? It's easier to read and understand later.
How did you decide to structure your CSS? First I tried different sheets for each page. I had to copy almost all the parts from main css, so I combined all into one css.
What was the most challenging piece of this assignment? Putting animated footer icons. It was first time i tried importing icons
Describe one area that you gained more clarity on when completing this assignment Overall layout, how different elements change the layout of the page

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes - in addition to being helpful for you as the developer, semantic sectioning tags are also important for accessibility tools like screen readers
Page fully loads no - see inline comment below
No broken links (regular or images) some - CSS on some pages
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text N/A
CSS
Using class and ID names in style declarations yes
Style declarations are DRY needs work - for example, .work p and .education p have exactly the same styling
Overall This is a good start. Once I was able to get your CSS to load, the site is attractively styled and easy to navigate. Just make sure you pay close attention to the details when working with CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants