Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets - Maria McGrew - Static Site #25

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Carets - Maria McGrew - Static Site #25

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2017

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had issues with misspellings, which I corrected, and an error I had that came up in each file was that I was missing headers. I didn't want a text header to be displayed though, so not sure what to do about that
Why is it important to consider and use semantic HTML? It is important because doing so helps enforce certain hierarchy and preference with the tags. I have a hover feature not showing up and it's making me wonder if it has to do with semantic html. Like perhaps it is being overridden elsewhere.
How did you decide to structure your CSS? I structured it by classes mainly, and the classes were based on the page's content.
What was the most challenging piece of this assignment? Layout and lining things up. I'm still working on understanding the parent/child relationship and where it would be useful in the CSS.
Describe one area that you gained more clarity on when completing this assignment The concept of block elements. I took one of my classmate's suggestions and added borders initially to each section. That helped clarify how things were initially laid out on the page.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Not very many commit, but good commit messages.
Answered comprehension questions For the misspellings, you may look for an html autocomplete for Atom, that might help some. I'm glad adding border helped figure out the layout a bit.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main No use of main, but other tags are used appropriately. One exception is footer because you're using a div tag instead. You should use the footer tag for footer sections of a page.
Appropriately using semantic tags: section, article, etc. Good use of section and article.
All images include alternate text Check
CSS
Using class and ID names in style declarations Check, Somewhat DRY CSS, good use of selectors in the Navigation.
Style declarations are DRY Some repeated rules, like text-align: center; and display: inline-block.
Overall Nice use of normalize. The pages are simply done, but they work. Good use of a layout in the code-journal. You hit all the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants