-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jan Edrozo | Caret #27
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
|
|
||
<section class="weekly-posts"> | ||
<article class="main-text"> | ||
<h2>Week 2</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably put each "post" in a different <article>
tag
<section class="main-text"> | ||
<h2>Recent Projects</h2> | ||
<hr /> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there were more content here, I might have put each "project" in a separate container that represented one "project" each
height: 0; | ||
} | ||
|
||
.clearfix { display: inline-block; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like you ended up using .clearfix anywhere?
Good work! Overall good, clean work. There are some places in HTML where the meaning of the content could be expressed more in HTML, such as a blog post being its own |
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions