Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jan Edrozo | Caret #27

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Jan Edrozo | Caret #27

wants to merge 14 commits into from

Conversation

JNEdrozo
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I got a few warnings and errors. For example, one warning said" Warning: Consider adding a lang attribute to the html start tag to declare the language of this document", so I added lang="en" in the html tag. Other examples, helped remind me to add tags like the title in the head of the other pages.
Why is it important to consider and use semantic HTML? It's important to use semantic HTML in order to give more meaning to different parts of my code. That way when I'm referencing those parts in my css file, it's easier to locate and read.
How did you decide to structure your CSS? I structured my CSS by using comments as headings to section off parts of my styling. For example, the general rules were placed at the very top. Afterwards are the headers, page-specific, and footer rule sets.
What was the most challenging piece of this assignment? It was designing and coming up with content. I also am trying to figure out how to use images better. For example, at some point I would like to include github, linkedin, and other icons in my portfolio page as part of the links.
Describe one area that you gained more clarity on when completing this assignment One area that I've gained clarity on is organizing nav and unordered lists in a horizontal line using display and inline blocks.

@tildeee
Copy link

tildeee commented Oct 4, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main x
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall


<section class="weekly-posts">
<article class="main-text">
<h2>Week 2</h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably put each "post" in a different <article> tag

<section class="main-text">
<h2>Recent Projects</h2>
<hr />
<p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there were more content here, I might have put each "project" in a separate container that represented one "project" each

height: 0;
}

.clearfix { display: inline-block; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like you ended up using .clearfix anywhere?

@tildeee
Copy link

tildeee commented Oct 4, 2017

Good work! Overall good, clean work. There are some places in HTML where the meaning of the content could be expressed more in HTML, such as a blog post being its own <article>. As it is right now, you just list all of the posts in the same container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants