Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bianca Fernandez |Pipes| Static Site #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

biciclista22
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? None that were beyond a warning or stylistic change.
Why is it important to consider and use semantic HTML? It is clearer to separate out what is going to be just text. The additions I made with div were done for CSS purposes. Personally, it makes it a lot clearer and easier for me to separate out the content from the visual representation.
How did you decide to structure your CSS? I knew I would want some consistency between the pages, especially when it came to the header and footer, so I knew those sections would go in the main css file. Then each page would have its respective, specialized css file that would load after the main.
What was the most challenging piece of this assignment? Designing and figuring out the layout. There is so much that could be done, but you have to make decisions along the way to get the assignment closer to completion.
Describe one area that you gained more clarity on when completing this assignment I think I focused a lot on trying to get more comfortable with floating text and images and then creating padding and margin space. I also worked on trying to work mostly with percentages with the hopes of trying to eliminate some of the odd formatting that happens when you switch between screens.

@Hamled
Copy link

Hamled commented Oct 3, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage No. We should always strive to commit our work into Git using a large number of small, focused commits that change just one specific thing.
Answered comprehension questions
Page fully loads
No broken links (regular or images)
Includes at least 4 pages and styling
HTML
Uses the high-level tags for organization: header, footer, main
Appropriately using semantic tags: section, article, etc.
All images include alternate text
CSS
Using class and ID names in style declarations
Style declarations are DRY Mostly. There's some additional work that could be done to DRY up the classes for likes/dislikes and the odd/even articles on the journal page.
Overall Nice site! I especially like the cool typewriter effect on the homepage!

margin-left: 30%;
margin-top: 20%
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be an extra closing curly-brace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants