Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gale Harrington - Carets #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

galestorm
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Whoops - didn't run an HTML validator as I went! Running it now, I definitely have some errors I don't fully understand. For example, the HTML validator is not happy with something about my body tag in about.html, but as far as I can tell, everything is working properly.
Why is it important to consider and use semantic HTML? For accessibility and so that browsers can appropriately interpret the structure of your webpage
How did you decide to structure your CSS? I used comments to divide styling that applied to different sections. After I had styled index.html, I mainly used classes and a few IDs to specify styling specific to other pages.
What was the most challenging piece of this assignment? Positioning in CSS and understanding how elements were inheriting properties/values from different parts of my code.
Describe one area that you gained more clarity on when completing this assignment I got a LOT better at using the chrome developer tools to pinpoint why weird stuff was happening.

@tildeee
Copy link

tildeee commented Oct 3, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage i know this was a small project, but not a lot of git commits this time!
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main didn't use main
Appropriately using semantic tags: section, article, etc. x
All images include alternate text nope
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

</nav>
<div class="white-space-bottom"></div>
</header>
<body>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect use of the <body> tag!

Very confusing, but <body> should describe where most of the HTML lives. This is in contrast to our <head> tag, which describes meta data for the website.

You'd probably want to use <main> here instead

<link href="../stylesheets/styles.css" rel="stylesheet"/>
<link href="https://fonts.googleapis.com/css?family=Maven+Pro" rel="stylesheet"/>
</head>
<header>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect a <body> tag right above this line, after closing head (</head>)

</li>
</ul>
</nav>
<div class="white-space-bottom"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using <div class="white-space-bottom"></div> it may be better to give a bottom margin to your nav


a #scrabble:hover {
opacity: 0.1;
border: solid;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a border on :hover actually shifts the content box of this a little bit, so the images shift on hover

September 17, 2017
</p>
<p class="blog-entry">
It's probably because you tried to give a property a value with an equals operator instead of a colon. Once you fix that, all your dreams will come true.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no! haha

@tildeee
Copy link

tildeee commented Oct 3, 2017

Nice website. Overall, I have concerns that you didn't get to appropriately place your <body> tag. I've left a comment above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants