-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gale Harrington - Carets #33
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
|
</nav> | ||
<div class="white-space-bottom"></div> | ||
</header> | ||
<body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect use of the <body>
tag!
Very confusing, but <body>
should describe where most of the HTML lives. This is in contrast to our <head>
tag, which describes meta data for the website.
You'd probably want to use <main>
here instead
<link href="../stylesheets/styles.css" rel="stylesheet"/> | ||
<link href="https://fonts.googleapis.com/css?family=Maven+Pro" rel="stylesheet"/> | ||
</head> | ||
<header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect a <body>
tag right above this line, after closing head (</head>
)
</li> | ||
</ul> | ||
</nav> | ||
<div class="white-space-bottom"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using <div class="white-space-bottom"></div>
it may be better to give a bottom margin to your nav
|
||
a #scrabble:hover { | ||
opacity: 0.1; | ||
border: solid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a border on :hover
actually shifts the content box of this a little bit, so the images shift on hover
September 17, 2017 | ||
</p> | ||
<p class="blog-entry"> | ||
It's probably because you tried to give a property a value with an equals operator instead of a colon. Once you fix that, all your dreams will come true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no! haha
Nice website. Overall, I have concerns that you didn't get to appropriately place your |
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions