Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lauren- pipes- static-site #36

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

laurenelee
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I discovered a bunch of things running this! I had not included alt descriptors until I ran it. Some things I did not understand, such as needing a header for a particular section... so I will be curious to find out if I am missing some semantics.
Why is it important to consider and use semantic HTML? It helps organizationally and also when DRYing up the CSS
How did you decide to structure your CSS? Based on the organization of the HTML file and
What was the most challenging piece of this assignment? Not knowing what the capabilities of HTML and CSS are and wanting to figure out JavaScript. I have visions of what it could look like and I am excited to figure out how to make those things a reality.
Describe one area that you gained more clarity on when completing this assignment I definitely understand flexbox a little better!

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions Regarding the second question, in addition to being a valuable tool for developers, semantic HTML is important for assistive technologies like screen readers.
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main some - I like that I see <header> and <footer> tags, but often times <main> is missing.
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Site is attractive and easy to navigate. Good work.

One nitpick: on the "blog" page, you have several independently scrolling panes within the larger page. This sort of thing is often difficult for users to scroll through intuitively - it's not always obvious what parts of the page will scroll. Allowing the content to take its natural height is often a better choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants