Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Pipes><Roxanne Agerone><Static Site> #39

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

RAgerone
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I didn't do this.
Why is it important to consider and use semantic HTML? There will be no problems with versions and the site will work.
How did you decide to structure your CSS? I went through and looked at my site after the html was completed and decided to change things incrementally.
What was the most challenging piece of this assignment? s.Centering object
Describe one area that you gained more clarity on when completing this assignment I gained clarity on filters and images. Not just that, but that's the most recent thing. I can't believe that this is the first time I've made a static site. I'm astounded at how much I've learned. It's also clear that I have some supportive classmates and fantastic teachers.

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes - I'm not sure I understand your answer to the second question, but semantic HTML is useful for a couple reasons. First, it's a tool for you the developer to use to help keep track of what's what. And second, it's important for assistive technologies like screen readers.
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text some - Alt text is important both if the image doesn't load and as something for accessibility tools to work with. Adding it to all images is a requirement in this course.
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Site is attractive and easy to navigate - good work! I like that you split your general and page-specific CSS out into different files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants