-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carets- Julia Meier - Static Website #40
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
|
<ul> | ||
<li><a href="portfolio.html">Codery<a/></li> | ||
<li><a href="hobby-blog.html">Hobby Blog<a/></li> | ||
<li><a href="about.html">About Me<a/></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no! you incorrectly closed all of these links in almost all of the pages. You typed <a/>
instead of </a>
so it's producing some funky HTML
</nav> | ||
</header> | ||
|
||
<body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not how the <body>
tag works: actually represents the idea of HTML that isn't the meta data (which goes in the tag)
Read more here: http://www.htmldog.com/references/html/tags/body/
You make this error in a few of the pages
<h1 class=page-heading>What's Been On My Mind Lately</h1> | ||
|
||
<div class="project BeePostMay15"> | ||
<img class="projectimage BeePostMay15-image" src="images/multiple-eggs.jpg" alt="laying-workers-evidence"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convention for class names is the hyphenate them, so it's like "project-image"
|
||
<body> | ||
<div class="arrow-headshot"> | ||
<img class="bananas" src="images/bananas.jpg"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no! You linked to the file bananas.jpg
here, when your file is named banana.jpg
!
I made a couple of comments on some errors you had in your code-- I want to make sure you understand how to use the tag and how to close tags, so let me know if you'd like to go over it together To run validations you can read through and find some online HTML validators here: https://github.com/Ada-Developers-Academy/textbook-curriculum/blob/master/05-html-css/html-intro.md#validate-your-html |
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions