Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets- Julia Meier - Static Website #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

julmeier
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I didn't run a validator! Not sure how to do this.
Why is it important to consider and use semantic HTML? I've found, when looking at other people's html, that it's really helpful in understanding the page layouts.
How did you decide to structure your CSS? I tried using the flex property for formatting most of the elements with CSS instead of the block property.
What was the most challenging piece of this assignment? Design! I've never taken design classes or done any design, so just coming up with simple aesthetic ideas was challenging.
Describe one area that you gained more clarity on when completing this assignment I played more with how to set up the layout (flex vs. block). I still want to play with those more, as well as learn about making tables, which I've seen used on past adies' sites.

@tildeee
Copy link

tildeee commented Oct 5, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) one broken image
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main not quite correct
Appropriately using semantic tags: section, article, etc. x
All images include alternate text on most but not all
CSS
Using class and ID names in style declarations x
Style declarations are DRY hmm...
Overall

<ul>
<li><a href="portfolio.html">Codery<a/></li>
<li><a href="hobby-blog.html">Hobby Blog<a/></li>
<li><a href="about.html">About Me<a/></li>
Copy link

@tildeee tildeee Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no! you incorrectly closed all of these links in almost all of the pages. You typed <a/> instead of </a> so it's producing some funky HTML

</nav>
</header>

<body>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not how the <body> tag works: actually represents the idea of HTML that isn't the meta data (which goes in the tag)

Read more here: http://www.htmldog.com/references/html/tags/body/

You make this error in a few of the pages

<h1 class=page-heading>What's Been On My Mind Lately</h1>

<div class="project BeePostMay15">
<img class="projectimage BeePostMay15-image" src="images/multiple-eggs.jpg" alt="laying-workers-evidence"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convention for class names is the hyphenate them, so it's like "project-image"


<body>
<div class="arrow-headshot">
<img class="bananas" src="images/bananas.jpg"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! You linked to the file bananas.jpg here, when your file is named banana.jpg!

@tildeee
Copy link

tildeee commented Oct 5, 2017

I made a couple of comments on some errors you had in your code-- I want to make sure you understand how to use the tag and how to close tags, so let me know if you'd like to go over it together

To run validations you can read through and find some online HTML validators here: https://github.com/Ada-Developers-Academy/textbook-curriculum/blob/master/05-html-css/html-intro.md#validate-your-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants