Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Site #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Static Site #41

wants to merge 1 commit into from

Conversation

lmarianarp19
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? No
Why is it important to consider and use semantic HTML? It is useful because It helps to have a better structure of the html and it makes easier to refers things at the future at the css file
How did you decide to structure your CSS? I made a css file per each page. I draw a design first and then I try to approach to that design.
What was the most challenging piece of this assignment? To understand what certain commands were doing, many times things behave in an unexpected way.
Describe one area that you gained more clarity on when completing this assignment How to use padding and floats.

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage no - As with Ruby code, when developing HTML/CSS it's important to keep a record of what changed and why. Please make sure to focus on git hygiene in future projects.
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) no - all the links in your site used absolute paths. This is something like /Users/mariana/ada/projects/week6/Static-Site/index.html, where it goes all the way from the root of the filesystem (/) to the current directory. While this works on your computer, it does not work on mine, because I do not have any folder named /Users/mariana. Instead, you should use relative paths, paths originating from the current directory, like index.html.

The way to tell the difference is that absolute paths always begin with a /, whereas relative paths never do.

I was able to do a search and replace in all your project files and get the site to load as expected.
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text no - Alt text is important both if the image doesn't load and as something for accessibility tools to work with. Adding it to all images is a requirement in this course.
CSS
Using class and ID names in style declarations no - make sure you're familiar with these concepts, as they'll become even more important once we start working with JavaScript.
Style declarations are DRY no - It looks like you've got the same stylings for header and footer in the CSS for each page. It might be cleaner to extract these shared styles to another stylesheet, and have each html page contain two stylesheet links, one to the shared styles and one to the page-specific ones.
Overall This is a good start. The page is attractive and easy to navigate, but many of the details about how you use CSS are not where I would like them to be. Whether or not you're particularly interested in design, being able to use CSS is an important skill, and it would be worthwhile to spend some extra time studying this.

@droberts-sea
Copy link

I did really appreciate the section on math news. A page after my own heart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants