Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kimberley Mackenzie - Carets #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimberleyamackenzie
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes. A couple minor spacing issues, and most notably, when I tried to put 2 divs within a span, which the validator pointed out was not permitted.
Why is it important to consider and use semantic HTML? It makes my code easier to read for other developers, and clarifies my intent in creating different sections of my HTML.
How did you decide to structure your CSS? I started with rulesets that applied to elements across pages, then focused on rulesets regarding the headers on my pages, going from the broadest rulesets that would apply to all headers, to the specific colors for each header on each page. I tried to follow that same broad to specific structure with other page elements. Towards the end, I included the CSS for the cube on my index page and the keyframes rulesets for the neon glow effects (which I felt to be the most specific, and thus should go towards the bottom to not 'overshadow' information that was more broadly applicable).
What was the most challenging piece of this assignment? Thinking about different pages, and the elements all pages should share versus what should be unique for a certain page, and then figuring out how to make those layout changes.
Describe one area that you gained more clarity on when completing this assignment DRYing up CSS, and when/how to do so.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Can't judge due to the weird Github bug.
Answered comprehension questions Check, well done
Page fully loads Check, loads a bit slow due to the 3D cube, but WOW.
No broken links (regular or images) Check
Includes at least 4 pages and styling Check, although the non CSSed content was minimal.
HTML
Uses the high-level tags for organization: header, footer, main You should probably use the main tag to section off the main, non header non footer part of the page. Otherwise good.
Appropriately using semantic tags: section, article, etc. Good, some divs for styling which was fine.
All images include alternate text Missing alt attributes!!!
CSS
Using class and ID names in style declarations Yep and good name for the classes.
Style declarations are DRY Could be slightly DRYer, with some rules repeated, but it's pretty DRY overall.
Overall I love all the CSS work you did, really neat. The style of the site was really cool. Neat stuff with the animations and 3D cube. Very unique. Nice work on this site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants