Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Bennett - Static Site #46

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bennettrahn
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML? It helps give your document structure and give other people an idea of what the code in this section is for.
How did you decide to structure your CSS? Messily. Its frustrating because if you want to format two things the same way - where do you put that? At the top of main? But then they're all disorganized? Its a mess. It has no flow and I don't like it.
What was the most challenging piece of this assignment? Design. How are you supposed to choose colors and fonts and images that look nice together?!?!?!?
Describe one area that you gained more clarity on when completing this assignment layout. I for the most part understand how to get things where I want them.

@Hamled
Copy link

Hamled commented Oct 2, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage
Answered comprehension questions
Page fully loads
No broken links (regular or images) Mostly. The social media/contact links on Contact page and in footer do not go anywhere.
Includes at least 4 pages and styling
HTML
Uses the high-level tags for organization: header, footer, main
Appropriately using semantic tags: section, article, etc.
All images include alternate text
CSS
Using class and ID names in style declarations
Style declarations are DRY
Overall Nice site! I love all the photos of your art, and also that really beautiful photo from Lauterbrunnen!

}

.content {
margin: ;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this declaration do anything, since it doesn't have a value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants