-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roxanne Agerone and Kimberley Zell - Pipes - VideoStoreConsumer #22
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Kimberley Zell <[email protected]>
…ything, as well as code we are not using and not going to use.
…thout a title and release date
Video Store ConsumerWhat We're Looking For
|
|
||
add(newMovie) { | ||
if(!newMovie.isValid()){ | ||
$('.display-status').html('') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems a little strange to me. It's defined on Movie, which implies you're currently inside a movie object, but it requires you to pass in a separate movie object and saves that to the database. Instead, it would probably be cleaner to have this function save this movie to the API, and call it on the new movie instead of the old.
Alternatively, you could say it's called on the old movie, but internally does the work of creating a new movie and saving that (work that is currently done in MovieView.add()
)
Video Store Consumer
Congratulations! You're submitting your assignment!
Comprehension Questions