Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laura & Severin - Carets #6

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Laura & Severin - Carets #6

wants to merge 33 commits into from

Conversation

s-wigg
Copy link

@s-wigg s-wigg commented Dec 20, 2017

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Severin learned how to approach styling from a systematic and analytical viewpoint from observing and pairing with Laura. I learned troubleshooting tips for the front end such as adding colors to show the boxes for different html elements. Laura understands Backbone better now from watching Severin's approach to structuring the relationships between views and models in Video Store.
What was one area of Backbone you gained more clarity on during this assignment? Collections versus models and the event calls within each (what's this within each element). We also encountered another asynchronous javascript issue and a great TA was able to help us learn about and use .then to overcome it.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We have radio buttons that allow you to toggle between searching within the inventory and within IMDB. We visually differentiated the IMDB search results because they have a red button so you can add them to inventory if you wish.
Describe how you handled rentals with Backbone? Our movies have inventory that is increased when in an IMDB search you click a button to add to inventory. We choose to spend our extra time on optional design elements such as taking in the average rating information from the API and displaying it.
Describe a DOM event your application handled In the Movie_list_view we have an event that is triggered when the All Movies button is clicked. The event triggers a render method to display all the movies in the inventory.
Describe a custom event your application handled We have a event that triggers off of the submission of the search form, that when triggered causes a custom method called submit to execute. Submit determines which type of search is being performed based on the value of the radio buttons and executes the appropriate search (inventory vs IMDB via API).
Do you have any recommendations on how we could improve this project for the next cohort? We thought it had the appropriate amount of required work with good optionals.

LauraAddams and others added 30 commits December 18, 2017 10:41
etching whole collect after search of collection
const MovieList = Backbone.Collection.extend({
model: Movie,
url: 'http://localhost:3000/movies',
parse(response) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't doing anything different than the default, overriding parse is unnecessary.

@CheezItMan
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution Check
Comprehension questions Check
General
Search functionality Check
Rental library listing functionality Check, nice work with the red checkmark
Add to rental library functionality Check
Underscore Templates Check
Overall Look & feel Really nice styling, I love the rollover effects and the differentiation between IMDB and local library items
Optionals nice that you got some basic testing in!
Overall You hit all the learning goals of the project, I'm glad you got to share expertise in styling and structure of Backbone. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants