Carets -- Guillermina Muro #40

murog · 2017-09-11T15:41:32Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I was considering making a hotel a class, so that I could potentially make more hotels in the future. Instead, I kept Hotel and all of its business logic within the scope of a module. I realized that there was no requirement to make more hotels, so a module was fine.
Describe a concept that you gained more clarity on as you worked on this assignment.	Inheritance! I had originally made Block its own class. However, I realized that it behaved very similarly to a reservation and took in many of the same inputs to initialize.
Describe a nominal test that you wrote for this assignment.	Checked to make sure a list of all_reservations created an array that matched the amount listed in the CSV file.
Describe an edge case test that you wrote for this assignment.	Many of my methods raise argument errors if they are given input ID's as anything else besides an integer. I tested to make sure strings, symbol, arrays and hashes would raise errors.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It was very helpful!! The project felt initially overwhelming, but the pseudocode -> failing test -> code -> passing test cycle made it much more manageable.

…ck in date is equal to a reservation's checkout date

…ailable rooms

…r for reserving a block to be raised if available rooms are less than the num of rooms called

…put id so it is more descriptive

… id so it is more descriptive

tildeee · 2017-09-24T22:19:48Z

I love this approach! The hotel as a module works great. I'm really happy with your work on the optionals of reading from a CSV-- and it was very close to working with writing to the CSV too! ;)

Your hotel is certainly doing a lot... which makes sense, because every other class is structured to represent some data, while hotel holds it all together.
The things to keep in mind is that it does a lot of stuff

making reservations/blocks
finding reservations/blocks
reading from CSVs/parsing it
building reservations/blocks from that CSV information/parsing it

and I could see some areas of being able to pull out the CSV parsing action.

Also, there are just some danger areas where your hotel does a lot of work that can be delegated to the other classes. I've made a few comments in some areas.

Overall good work though

tildeee · 2017-09-24T22:20:19Z

lib/hotel.rb

+    return all_blocks
+  end
+
+  def self.cost(input_reservation_id)


you should reuse self.find_reservation here!

tildeee · 2017-09-24T22:21:06Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	x
Answer comprehension questions	x
Design
Each class is responsible for a single piece of the program	x
Classes are loosely coupled	x
Wave 1
List rooms	x
Reserve a room for a given date range	x
List reservations for a given date	x
Calculate reservation price	x
Invalid date range produces an error	x
Test coverage	x
Wave 2
View available rooms for a given date range	x
Reserving a room that is not available produces an error	x
Test coverage	x
Wave 3
Create a block of rooms	x
Check if a block has rooms	x
Reserve a room from a block	x
Test coverage	x
Additional Feedback

tildeee · 2017-09-24T22:21:35Z

by the way, I love the process of working through this project that you described in your comprehension questions ;)

tildeee · 2017-09-24T22:24:03Z

lib/hotel.rb

+    unavailable_rooms = []
+    all_reservations = self.all_reservations
+    all_reservations.each do |reservation|
+      if (begin_search >= reservation.check_in) && (begin_search < reservation.check_out) && (end_search >= reservation.check_in) && (end_search <= reservation.check_out)


maybe this logic can be returned from a reservation itself if you pass in the begin_search and end_search properties instead! That way, hotel doesn't need to know that a reservation has a .check_in and a .check_out

tildeee · 2017-09-24T22:24:19Z

lib/hotel.rb

+    blocked_rooms = []
+    all_the_blocks = self.all_blocks
+    all_the_blocks.each do |block|
+      if (begin_search >= block.check_in) && (begin_search < block.check_out) && (end_search >= block.check_in) && (end_search <= block.check_out)


same as the other comment

tildeee · 2017-09-24T22:27:35Z

lib/hotel.rb

+    block = self.find_block(block_id)
+    raise ArgumentError.new "Block ID is not found" if !(block.is_a? Hotel::Block)
+    # block.add_rooms
+    availability = block_available(block_id)


in this method, you've already found the block object and stored it in block, but then you redo that work in calling block_available and passing in the block_id instead of the block itself.

I would refactor this so that it relies on block more, and lets block return internal information about itself

tildeee · 2017-09-24T22:28:23Z

lib/hotel.rb

+    array_check_out =[block.check_out.year, block.check_out.month, block.check_out.day]
+    new_reservation = Hotel::Reservation.new(5, block.rooms[0].id, array_check_in, array_check_out, block.block_id)
+    # block.add_reservations # => does nothing currently, would work if I was writing new reservations to CSV...)-':'
+    block.reservations << (new_reservation)


ideally instead of shoveling into a block's internal property reservations, you would use a method

murog added 30 commits September 5, 2017 13:29

added Rakefile

556fd2d

create class files and test files

0f9313f

wrote pseudocode for wave1

193aa14

green test create instance of room

5cc1ce8

added passing tests for creating instance of room and 20 hotel rooms

6d0c0c0

passing self.all rooms test

caaad48

added passing tests find by room

05df441

added reservations.csv

69b5087

added find total cost by reservation_id

948422c

find reservation based on date tests are passing

a40e794

all wave 1 reqs are passing

52e1f6e

wrote pseudocode and tests for first user story

95d5d61

can search for available rooms based on date

42d2163

updated available rooms to not consider a room unavailable if the che…

ee90848

…ck in date is equal to a reservation's checkout date

wrote failing tests for reserve_room

6588ebb

Hotel responds to reserve_room

c250f61

reserve room passing tests

1fc6199

wave 2 passing

68c903e

started wave 3, created block tests, csv and ruby files

4300179

Block initialized with rate, num of rooms, check in and check out dates

3f24851

passing tests for Hotel.all_blocks

184841d

blocks are intiated with rooms with given date range

7d84609

i messedu p

321ee8b

wrote test for checking blocks when checking available rooms

0e51766

truly_available hotel passes test for checking blocks

83169a9

added block_id attribute to blocks

2aecad4

wrote failing test for finding reservation by id

ed04707

added reservations attribute to blocks, added find reservation by id

38c6885

wrote failing tests for find reservation by block id

0613ddd

wrote failing test for block_available

91a740b

murog added 18 commits September 6, 2017 18:11

updated failing test for block available to check for integer

ed0662b

wrote failing tests for find block by input id

9d3dbf0

find block passing

43a8ec4

wrote failing tests for reserve_block_room

0ceabc4

can create reservation for block

4fca524

blocks have reservations

5f8b8b4

wrote failing test for hotel.reserving block

09ae73c

can reserve block through hotel, will return error if there are no av…

fd094fc

…ailable rooms

checked self.cost to take input_reservation_id, changed argument erro…

b86f790

…r for reserving a block to be raised if available rooms are less than the num of rooms called

made reservation cost a private method

92a06f5

update argument for reserve block room to take block_id instead of in…

0d34d0d

…put id so it is more descriptive

update argument for block available to take block_id instead of input…

b5861d8

… id so it is more descriptive

finalized all blocks tests

66f8a1d

finalized cost tests

5cb8ab7

finalized hotel room numbers tests

8bd5695

finalized find reservation tests

cb7ebd0

finalized all rooms tests

7610816

finalized tests for making reservation within block

22ae01f

tildeee reviewed Sep 24, 2017

View reviewed changes

lib/hotel.rb

return all_blocks

end

def self.cost(input_reservation_id)

Copy link

tildeee Sep 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should reuse self.find_reservation here!

tildeee reviewed Sep 24, 2017

View reviewed changes

murog added 2 commits October 2, 2017 08:24

design activity

fac56e9

updated hotel available_rooms and blocked_rooms

efd0873

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carets -- Guillermina Muro #40

Carets -- Guillermina Muro #40

murog commented Sep 11, 2017

tildeee commented Sep 24, 2017 •

edited

Loading

tildeee Sep 24, 2017

tildeee commented Sep 24, 2017

tildeee commented Sep 24, 2017

tildeee Sep 24, 2017

tildeee Sep 24, 2017

tildeee Sep 24, 2017

tildeee Sep 24, 2017

Carets -- Guillermina Muro #40

Are you sure you want to change the base?

Carets -- Guillermina Muro #40

Conversation

murog commented Sep 11, 2017

Hotel

Comprehension Questions

tildeee commented Sep 24, 2017 • edited Loading

tildeee Sep 24, 2017

Choose a reason for hiding this comment

tildeee commented Sep 24, 2017

Hotel

What We're Looking For

tildeee commented Sep 24, 2017

tildeee Sep 24, 2017

Choose a reason for hiding this comment

tildeee Sep 24, 2017

Choose a reason for hiding this comment

tildeee Sep 24, 2017

Choose a reason for hiding this comment

tildeee Sep 24, 2017

Choose a reason for hiding this comment

tildeee commented Sep 24, 2017 •

edited

Loading