Carets- Julia Meier- Hotel #43

julmeier · 2017-09-11T15:55:36Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	In creating the initial design, I debated as to which class should handle making reservations. I ultimately chose the Hotel class to check, store and modify reservations, because I wanted it to mimic real life in that, "a hotel makes reservations/ has rooms". The reservation, block and room classes did not take on any of this functionality. I could use some practice on how to handle exceptions.
Describe a concept that you gained more clarity on as you worked on this assignment.	This assignment really helped me understand how and when to make objects, and how to call them from other classes and make modifications.
I wish I could have gotten to the optional assignment of creating a CLI, because I think it would have helped me better understand how to implement rescuing exceptions- right now, I just created custom exceptions, but haven't yet implemented a course of action in how these errors are rescued.
Describe a nominal test that you wrote for this assignment.	One nominal test of my hotel class looked to see that the first reservation of a block was unassigned and then changed to assigned after the assign_block_reservation method.
Describe an edge case test that you wrote for this assignment.	I wrote an edge case test about the assign_block_reservation method that checked to see that, after three block reservations were change to "assigned", that the fourth tim the method was called, there was only 1 reservation left as "unassigned". This test was extremely helpful as I found out that my find_unassigned_block_reservations method in the code was not correctly identifying unassigned reservations. Before I fixed it, it would return all reservations in a block - the assign_block_reservation method was not effectively changing the status of the reservations.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It's helpful to write out the intention and general idea of what you're trying to accomplish first; it's easy to just start coding away so writing pseudocode first helped to slow me down.

… started outlining rooms.rb

…ests

… initialize. Removed self.all method. Added list_room method- passes tests

…es first test for initialization

… a new reservation instance

…zation

… reservations in the reservations_array

…stance variable of hotel that can be used for all the tests

… of a reservation. Added a Custom_Exceptions file

…pulate it yet

…working

…. It passes the first two tests

…ount for search dates that fell exactly on the checkin and checkout dates of existing reservations.

…e an available room was incorrect).

… available to reserve

… 173-178

…arranged the order of methods

…tial tests

… of rooms

….added a status attribute to the reservations class and altered find_rooms_available method in the hotel class to consider the status attribute in assessing a room's availability

…osnideration of the status in the find_rooms_available method.

…tests

…hich there are no block reservations

…or a block. I added a new error if the user attempts to make a block reservation for greater than 5 rooms. Passes initial tests

…ation- the change of the reservation status from unassigned to assigned is not sticking.

…otential matches for block partynames (since we need to know the exact name and spelling to look up block information)

CheezItMan · 2017-09-20T20:17:57Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	A lot of commits and good messages, that's great!
Answer comprehension questions	Check, you did implement a rescue in your `Reservation` class which caught an ArgumentError and then generated a custom error of your own.
Design
Each class is responsible for a single piece of the program	You've got almost all the functionality of your project in the `Hotel` class. You should allocate actions that go along with the concept of reservation or block in those objects. Like rooms remaining in a block, or total cost for a reservation.
Classes are loosely coupled	They're loosely coupled because none of the classes outside of Hotel is really doing business logic.
Wave 1
List rooms	Check, but see my notes in the `Hotel` class.
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check, but it's done via very tight coupling between `Hotel` and `Reservation`.
Invalid date range produces an error	There's no check for if a reservation's check-in date is before the check-out date.
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	It picks a random room, but it does check to see if none are available
Wave 3
Create a block of rooms	Check
Check if a block has rooms	Check
Reserve a room from a block	Check via `find_unassigned_block_reservations`
Test coverage	99%!
Additional Feedback	Take a look at the Sandy Metz book again along with my in-line comments. You've got some textbook examples of tight coupling, and I highlighted at least one. You also have all the work being done in `MyHotel` instead of providing helper methods where appropriate in the other classes. Think about what you should be able to ask a reservation or a block. What questions should a reservation be able to answer? Not a bad submission, but a difficult design to change or adapt due to all the work being very nested into `MyHotel`.

CheezItMan

A few in-code notes.

CheezItMan · 2017-09-20T19:36:32Z

lib/reservation.rb

+
+    attr_accessor :check_in_date, :check_out_date, :room, :HOTEL, :cost, :status, :block_reserved
+
+    HOTEL = Hotel_Chain::MyHotel.new


This looks like you can only have ONE hotel EVER.

CheezItMan · 2017-09-20T19:38:01Z

lib/reservation.rb

+module Hotel_Chain
+  class Reservation
+
+    attr_accessor :check_in_date, :check_out_date, :room, :HOTEL, :cost, :status, :block_reserved


You have a lot of attr_accessor methods here, but they don't all get set values, like cost. How does that get calculated?

You should either have a method that does the calculation for the cost of the reservation or set the cost in the initialize method.

CheezItMan · 2017-09-20T19:57:29Z

lib/hotel.rb

+      reservations_on_date.each do |reservation|
+        array  << "Room #{reservation.room.room_id} is reserved from #{reservation.check_in_date} to #{reservation.check_out_date}"
+      end
+      ap array


When you turn things in, it's best to take out extraneous puts or ap commands. It makes running things more messy than it would be otherwise.

CheezItMan · 2017-09-20T19:58:25Z

lib/hotel.rb

+require 'pry'
+
+module Hotel_Chain
+  class MyHotel


Why not call this Hotel instead of MyHotel? MyHotel sounds like it's an individual Hotel instance rather than a class.

CheezItMan · 2017-09-20T19:59:15Z

lib/hotel.rb

+module Hotel_Chain
+  class MyHotel
+
+    attr_reader :array_of_rooms, :reservations_array, :blocks_array


You should probably just name these, rooms, reservations, or blocks because you might in the future change how you implement these data structures and you want to separate implementation from how they're used.

Also do you want to give the user direct access to the rooms and reservations and blocks, instead of making them go through your methods. With this they could change them directly bypassing MyHotel methods.

CheezItMan · 2017-09-20T20:01:58Z

lib/hotel.rb

+    def find_reservations_by_date(date)
+      reservations_on_date = []
+      @reservations_array.each do |reservation|
+        if (reservation.check_in_date...reservation.check_out_date).cover?(Date.strptime(date, "%m/%d/%Y"))


Just a note, this makes a new Date object each time the loop iterates. You instead create one before the loop and then use it here.

Just a bit of optimization.

More seriously, this method works directly with the Reservation object's data attributes, instead this logic should go into the Reservation class and Hotel should simply ask, ""Hey does this date overlap with you?" using an instance method and should get back a true/false response.

This is an example of tight coupling.

CheezItMan · 2017-09-20T20:06:01Z

lib/hotel.rb

+        new_reservation.room = @array_of_rooms[0]
+        @reservations_array << new_reservation
+        return new_reservation
+      elsif @reservations_array.length > 0


This elseif is unnecessary, else would be enough since if it's not 0 it's greater than 0.

CheezItMan · 2017-09-20T20:07:49Z

lib/hotel.rb

+    end
+
+    def find_rooms_available(check_in_date, check_out_date)
+      unavailable_rooms = []


This method seems overly complicated.

CheezItMan · 2017-09-20T20:08:39Z

lib/hotel.rb

+
+    def reserve_block(party_name, check_in, check_out, no_of_rooms, room_rate)
+      if no_of_rooms > 5
+        raise ExceededRoomLimitForBlocksError


Good use of a custom Error.

CheezItMan · 2017-09-20T20:10:11Z

lib/hotel.rb

+      else
+        no_of_rooms.times do |room|
+          new_reservation = store_reservation(check_in, check_out)
+          new_reservation.room.rate = room_rate


room rate should be passed in when you create the reservation.

…er feedback

julmeier added 30 commits September 5, 2017 14:05

created rake file and spec helper, created initial test for rooms.rb,…

a94a144

… started outlining rooms.rb

Room class passes initialization tests

2f7d797

added Hotel class and modified Room class, both pass initialization t…

26db587

…ests

Hotel and Room classes pass additional tests

9f29417

made additional changes to the Hotel and Room classes

7dee76c

fixed everything. redid MyHotel class to create rooms in hotel in the…

69acd00

… initialize. Removed self.all method. Added list_room method- passes tests

hotel and room classes pass tests, added Reservation class which pass…

e9e19fb

…es first test for initialization

fixed Reservation class initialization test and passed 2nd test

72eafc8

altered tests and code to allow input of an actual date when creating…

5b382e5

… a new reservation instance

tested that a reservation has a check-in date

6a2a97e

Reservation class accepts a checkin and checkout date during initiali…

a2a3b62

…zation

initializing a reservation now creates a cost

34b7b36

added store_reservation method to MyHotel class, which stores all new…

2816d6c

… reservations in the reservations_array

altered hotel_spec to have a before-do at the top to initialize an in…

5ae6a02

…stance variable of hotel that can be used for all the tests

passes test to return a an array of reservations on a given date

b6a86ed

error is raised if incorrect date format is applied to initialization…

fea6898

… of a reservation. Added a Custom_Exceptions file

rooms available method returns an array, but does not yet corretly po…

25dee3d

…pulate it yet

method to find available rooms for a certain date range is still not …

c6daf3c

…working

tried another way to make a rooms_available method in the hotel class…

e235d39

…. It passes the first two tests

completed testing for the find_available_room method

9edb3ee

added additional test to find_rooms_available method

e72c1cd

one test still failing: Hotel_spec test_0007

10533e1

fixed bug in hotel class. the find_rooms_available method did not acc…

c235d6c

…ount for search dates that fell exactly on the checkin and checkout dates of existing reservations.

fixed bugs in find_available_rooms method (the logic for how to defin…

436d51b

…e an available room was incorrect).

program raises a NoReservationAvailable error when there are no rooms…

fe89f75

… available to reserve

added additional test for store_reservation method - hotel_spec lines…

288e71d

… 173-178

added and tested a print_reservations_by_date method to hotel, and re…

245ac65

…arranged the order of methods

created block class and associated methods in hotel class, passes ini…

92ea61a

…tial tests

completed first user story- As an administrator, I can create a block…

f886d28

… of rooms

last commit incorrectly stated I had completed the first user story..…

fbc9594

….added a status attribute to the reservations class and altered find_rooms_available method in the hotel class to consider the status attribute in assessing a room's availability

julmeier added 11 commits September 8, 2017 15:56

added a block_reserved attribute to the reservations class. removed c…

eac82f0

…osnideration of the status in the find_rooms_available method.

created find_unassigned_block_reservations method - passes first two …

305b2e4

…tests

Raises a NoPartyByThatNameError if the user enters a party_name for w…

54308c2

…hich there are no block reservations

I had missed the constraint that a max of 5 rooms could be reserved f…

bf4cd7e

…or a block. I added a new error if the user attempts to make a block reservation for greater than 5 rooms. Passes initial tests

tests pass for assign_block_reservation method

b1b8d9b

Please DO NOT review this version. Found a bug in assign_block_reserv…

41f3657

…ation- the change of the reservation status from unassigned to assigned is not sticking.

fixed bug on assign_block_reservation method

1cb8178

tested AllBlockRoomsAssignedError

4e79788

added the match_block_partyname method, which can be used to lookup p…

1ca1e06

…otential matches for block partynames (since we need to know the exact name and spelling to look up block information)

added method to Allow a user to set different rates for different rooms

702a62b

cleaning up files for review

f2aac8b

CheezItMan reviewed Sep 20, 2017

View reviewed changes

Hotel Revisited- answered questions and made changes to hotel files p…

379b9ff

…er feedback

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carets- Julia Meier- Hotel #43

Carets- Julia Meier- Hotel #43

julmeier commented Sep 11, 2017

CheezItMan commented Sep 20, 2017

CheezItMan left a comment

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017

CheezItMan Sep 20, 2017


		attr_accessor :check_in_date, :check_out_date, :room, :HOTEL, :cost, :status, :block_reserved

		HOTEL = Hotel_Chain::MyHotel.new

Carets- Julia Meier- Hotel #43

Are you sure you want to change the base?

Carets- Julia Meier- Hotel #43

Conversation

julmeier commented Sep 11, 2017

Hotel

Comprehension Questions

CheezItMan commented Sep 20, 2017

Hotel

What We're Looking For

CheezItMan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment