Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS indepdent paths for monkey, hippocampus and synthetic data #169

Merged

Conversation

stes
Copy link
Member

@stes stes commented Aug 23, 2024

Switch all paths, especially in cebra.datasets, to pathlib for compatibility across operating systems.

Originally added by @gonlairo , this PR is a squashed variant of:

(Needs more tests)

@stes stes self-assigned this Aug 23, 2024
@cla-bot cla-bot bot added the CLA signed label Aug 23, 2024
@MMathisLab MMathisLab added documentation Improvements or additions to documentation 🐞 fix labels Aug 23, 2024
@stes stes force-pushed the rodrigo/fix-monkey-synth-hippo-path-for-windows-squashed branch from 5783d12 to 7c7066f Compare August 23, 2024 22:53
@stes stes force-pushed the rodrigo/fix-monkey-synth-hippo-path-for-windows-squashed branch from 7c7066f to d7d89ad Compare August 24, 2024 09:28
@MMathisLab MMathisLab self-requested a review August 24, 2024 09:57
@@ -113,6 +113,8 @@ def test_monkey():
def test_allen():
from cebra.datasets import allen

pytest.skip("Test takes too long")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to skip? :D

Copy link
Member

@MMathisLab MMathisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did not test on Windows (don't have access); one Q on test skip!

@MMathisLab MMathisLab merged commit 9e14790 into main Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed documentation Improvements or additions to documentation 🐞 fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants