tensorboard-controller: fix binding issue (kubeflow/kubeflow#5925)

Adembc · Jun 22, 2024 · 46a89fe · 46a89fe
1 parent 7c45926
commit 46a89fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/notebooks/tensorboard-controller/config/crd/bases/tensorboard.kubeflow.org_tensorboards.yaml b/notebooks/tensorboard-controller/config/crd/bases/tensorboard.kubeflow.org_tensorboards.yaml
@@ -3,6 +3,8 @@
 apiVersion: apiextensions.k8s.io/v1beta1
 kind: CustomResourceDefinition
 metadata:
+  annotations:
+    controller-gen.kubebuilder.io/version: v0.2.5
   creationTimestamp: null
   name: tensorboards.tensorboard.kubeflow.org
 spec:
@@ -12,7 +14,7 @@ spec:
     listKind: TensorboardList
     plural: tensorboards
     singular: tensorboard
-  scope: ""
+  scope: Namespaced
   subresources:
     status: {}
   validation:

diff --git a/notebooks/tensorboard-controller/controllers/tensorboard_controller.go b/notebooks/tensorboard-controller/controllers/tensorboard_controller.go
@@ -255,6 +255,7 @@ func generateDeployment(tb *tensorboardv1alpha1.Tensorboard, log logr.Logger, r
 							WorkingDir:      "/",
 							Args: []string{
 								"--logdir=" + mountpath,
+								"--bind_all",
 							},
 							Ports: []corev1.ContainerPort{
 								{